Remove DiagH class in hsolver #5307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Should diag.h be totally removed from source code? |
I think this should be done, since diagH has no effect anymore. @Cstandardlib |
mohanchen
approved these changes
Oct 23, 2024
This was referenced Oct 23, 2024
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
* Remove diagh Pointer in lcao solver tests * Remove const_nums in diagh.h * Remove diago_david dependency on diagh.h * Remove diago_dav_subspace dependency on diagh.h * Remove diago_cg dependency on diagh.h * Remove diago_bpcg dependency on diagh.h * Remove diago_lapack&scalapack dependency on diagh.h * Remove diago_lapack dependency on diagh.h * Add hamilt.h to diago_lapack * Remove diago_elpa dependency on diagh.h * Remove diago_cusolver dependency on diagh.h * Remove diago_pexsi dependency on diagh.h * Remove diago_cusolvermp&elpa_native dependency on diagh.h * Remove hsolver_lcaopw dependency on diagh.h * Remove hsolver dependency on diagh.h --------- Co-authored-by: Haozhi Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fix #5203
DiagHfrom all related code.diagh.hin lcao are replaced bymacros.hforRealtype,hamilt.hforHamilt&psi. Also in pw, some utilities liketimerandtitlefunctions inmodule_base.psiis included inhamilt.